[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] x86emul: simplify asm() constraints



>>> On 10.03.15 at 20:48, <andrew.cooper3@xxxxxxxxxx> wrote:
> Did you observe any code changes simply from changing = constraints to
> +, or did we get very lucky in with the generated code?

I think it's not really unexpected that there was no change, since
the operands were all memory-only ones (and generally gcc avoids
to address the same memory location in multiple different ways).

> I think it might be a very wise idea to switch to using symbolic names. 
> This code is very complicated and has many ways to go subtly wrong.

Let's save this for another day.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.