Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Mar 06, 2015 at 02:30:27PM +0000, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v6 20/23] libxlu: record line and column number 
> when parsing values"):
> > Ack. This is how it looks like now. The changes are
> > 
> > 1. Use YYLTYPE instead of line and column.
> 
> This is better but why not have YYLTYPE inside XLU_ConfigValue ?
> 

That appears to cause some kind of circular inclusion problem. I will
see what I can do.

> > 2. Handle empty rule inside list_mk and string_mk (that is when YYLTYPE
> >    points to NULL)
> 
> I hadn't spotted this in the previous patch.  Why not use `yyloc', the
> location of the lookahead token ?
> 

I think you mean yylloc. yyloc is internal variable.

> > +    if (loc) {
> > +        value->line = loc->first_line;
> > +        value->column = loc->first_column;
> > +    } else
> > +        value->line = value->column = 0;
> 
> This code appears twice.
> 

If I use yylloc (or yyloc) this hunk will just be gone.

Wei.

> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel