Re: [Xen-devel] [PATCH] xsm/policy: remove gawk-ism line in Makefile

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-03-03 at 12:44 +0000, Wei Liu wrote:
> Translate gawk regex to mawk regex to allow using mawk. The new regex
> works on both gawk and mawk.

I think [[:alpha:]] might include A-Z too, but I presume that doesn't
affect our inputs or your tests would have failed. So for my part:

> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> ---
>  tools/flask/policy/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/flask/policy/Makefile b/tools/flask/policy/Makefile
> index 54a845b..58d9ce1 100644
> --- a/tools/flask/policy/Makefile
> +++ b/tools/flask/policy/Makefile
> @@ -86,7 +86,7 @@ DETECTED_MODS := $(sort $(foreach 
> dir,$(ALL_LAYERS),$(wildcard $(dir)/*.te)))
>  MODENABLED := on
>  
>  # extract settings from modules.conf
> -ENABLED_MODS := $(foreach mod,$(shell awk '/^[[:blank:]]*[[:alpha:]]/{ if 
> ($$3 == "$(MODENABLED)") print $$1 }' $(MOD_CONF) 2> /dev/null),$(subst 
> ./,,$(shell find -iname $(mod).te)))
> +ENABLED_MODS := $(foreach mod,$(shell awk '/^[ \t]*[a-z]/{ if ($$3 == 
> "$(MODENABLED)") print $$1 }' $(MOD_CONF) 2> /dev/null),$(subst ./,,$(shell 
> find -iname $(mod).te)))
>  
>  ALL_MODULES := $(filter $(ENABLED_MODS),$(DETECTED_MODS))
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel