Re: [Xen-devel] [PATCH net-next 06/14] xen: Use eth_<foo>_addr instead of memset

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Mar 02, 2015 at 07:54:51PM -0800, Joe Perches wrote:
> Use the built-in function instead of memset.
> 
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
>  drivers/net/xen-netback/interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/interface.c 
> b/drivers/net/xen-netback/interface.c
> index f38227a..4ae98e2 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -438,7 +438,7 @@ struct xenvif *xenvif_alloc(struct device *parent, 
> domid_t domid,
>        * stolen by an Ethernet bridge for STP purposes.
>        * (FE:FF:FF:FF:FF:FF)
>        */
> -     memset(dev->dev_addr, 0xFF, ETH_ALEN);
> +     eth_broadcast_addr(dev->dev_addr);
>       dev->dev_addr[0] &= ~0x01;
>  
>       netif_carrier_off(dev);
> -- 
> 2.1.2

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel