Re: [Xen-devel] [PATCH 1/4] vscsiif.h: remove reference to WWN

[Olaf Hering <olaf@xxxxxxxxx>]

On Mon, Mar 02, Olaf Hering wrote:

> On Mon, Mar 02, Juergen Gross wrote:
> 
> > On 03/02/2015 11:15 AM, Olaf Hering wrote:
> > >The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation.
> > >Remove incorrect reference to WWN because it was never supported. And
> > >its not clear how it could be supported. p-devname can be used to store
> > >a config string.
> > 
> > The pvops backend driver should support the WWN notation. In case it
> > isn't working this is a bug which should be repaired.
> > 
> > I implemented the WWn version before adding the possibility to use
> > h:c:t:l due to compatibility with xend...
> 
> This requires changes to the libxl parser. I was not aware of that pvops
> uses such notation.

And in fact it expects a colon in scsiback_add_translation_entry(). So
my patch is still valid. If another implementation comes along which
requires something else than h:c:t:l the comment will be adjusted.
But, maybe the comment is just incomplete and the WWN example lacks the
colon.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel