Re: [Xen-devel] [PATCH] stubdom: fix make clean and distclean on a freshly cloned tree

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-03-02 at 14:25 +0000, Wei Liu wrote:
> > > > +endif
> > > > +
> > > >  -include $(XEN_ROOT)/config/Stubdom.mk
> > > >  
> > > >  GNU_TARGET_ARCH:=$(XEN_TARGET_ARCH)
> > > > diff --git a/stubdom/c/Makefile b/stubdom/c/Makefile
> > > > index c646c26..b252dca 100644
> > > > --- a/stubdom/c/Makefile
> > > > +++ b/stubdom/c/Makefile
> > > > @@ -1,6 +1,8 @@
> > > >  XEN_ROOT = $(CURDIR)/../..
> > > >  
> > > > +ifeq (,$(findstring clean,$(MAKECMDGOALS)))
> > > >  include $(XEN_ROOT)/Config.mk
> > 
> > XEN_ROOT/Config.mk always exists. Did you misread it as MINI_OS?
> > 
> 
> No, I don't think I misread.
> 
> The subtle thing is that XEN_ROOT/Config.mk has
> 
>    include $(XEN_ROOT)/config/$(XEN_OS).mk
> 
> Here XEN_OS=MiniOS. Then in MiniOS.mk
> 
>    include $(XEN_ROOT)/extras/mini-os/Config.mk
> 
> If you don't have extra/mini-os you get an error.

Ah, that is definitely worth spelling out in the commit log.

(this is the underlying cause of the comments on the first hunk too)

> 
> Wei.
> 
> > (and in the next hunk too)
> > 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel