IOMMU/x86: correct page_list_first() use Comparing its result against NULL is unsafe when page lists use normal list entries for linking together - page_list_empty() needs to be used instead. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -85,8 +85,9 @@ int arch_iommu_populate_page_table(struc * first few entries. */ page_list_move(&d->page_list, &d->arch.relmem_list); - while ( (page = page_list_first(&d->page_list)) != NULL && - (page->count_info & (PGC_state|PGC_broken)) ) + while ( !page_list_empty(&d->page_list) && + (page = page_list_first(&d->page_list), + (page->count_info & (PGC_state|PGC_broken))) ) { page_list_del(page, &d->page_list); page_list_add_tail(page, &d->arch.relmem_list);