Re: [Xen-devel] [PATCH 3/5] hvmemul_do_io: If the send to the ioreq server failed do not retry.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.01.15 at 01:52, <dslutz@xxxxxxxxxxx> wrote:
> I.E. do just what no backing DM does.

_If_ this is correct, the if() modified here should be folded with the
one a few lines up. But looking at the description of the commit that
introduced this (bac0999325 "x86 hvm: Do not incorrectly retire an
instruction emulation...", almost immediately modified by f20f3c8ece
"x86 hvm: On failed hvm_send_assist_req(), io emulation...") I doubt
this is really what we want, or at the very least your change
description should explain what was wrong with the original commit.

Jan

> --- a/xen/arch/x86/hvm/emulate.c
> +++ b/xen/arch/x86/hvm/emulate.c
> @@ -228,7 +228,11 @@ static int hvmemul_do_io(
>          {
>              rc = X86EMUL_RETRY;
>              if ( !hvm_send_assist_req(&p) )
> +            {
> +                /* Since the send failed, do not retry */
> +                rc = X86EMUL_OKAY;
>                  vio->io_state = HVMIO_none;
> +            }
>              else if ( p_data == NULL )
>                  rc = X86EMUL_OKAY;
>          }
> -- 
> 1.8.4




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel