Re: [Xen-devel] [PATCH v3] PCI: Add guard to avoid mapping a invalid msix base address

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.01.15 at 04:54, <wangyijing@xxxxxxxxxx> wrote:
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -694,11 +694,16 @@ static void __iomem *msix_map_region(struct pci_dev 
> *dev, unsigned nr_entries)
>  {
>       resource_size_t phys_addr;
>       u32 table_offset;
> +     unsigned long flags;
>       u8 bir;
>  
>       pci_read_config_dword(dev, dev->msix_cap + PCI_MSIX_TABLE,
>                             &table_offset);
>       bir = (u8)(table_offset & PCI_MSIX_TABLE_BIR);
> +     flags = pci_resource_flags(dev, bir);
> +     if (!flags || (flags & IORESOURCE_UNSET))
> +             return NULL;

Mind explaining what relevance the checking of flags against zero has
(also in the Xen counterpart)? The patch description says nothing in
this regard...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel