Re: [Xen-devel] [PATCH v4 03/21] libxc: allocate memory with vNUMA information for PV guest

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2015-01-23 at 11:13 +0000, Wei Liu wrote:
> +        /* Setup dummy vNUMA information if it's not provided. Note
> +         * that this is a valid state if libxl doesn't provide any
> +         * vNUMA information.
> +         *
> +         * The dummy values make libxc allocate all pages from
> +         * arbitrary physical. This is the expected behaviour if no

                                ^ nodes ?

> +         * vNUMA configuration is provided to libxc.
> +         *
> +         * Note that the following hunk is just for the convenience of
> +         * allocation code. No defaulting is happening in libxc.
> +         */
> +        if ( dom->nr_vnuma_info == 0 )
> +        {

ASSERT(!dom->vnuma_info)?

Other than those minor issues/suggestions looks good:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel