Re: [Xen-devel] [PATCH v4 00/14] Enable vTPM subsystem on TPM 2.0

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 28 Jan 2015, Xu, Quan wrote:
> > -----Original Message-----
> > From: Stefano Stabellini [mailto:stefano.stabellini@xxxxxxxxxxxxx]
> > Sent: Tuesday, January 27, 2015 11:48 PM
> > To: Xu, Quan
> > Cc: Stefano Stabellini; keir@xxxxxxx; ian.campbell@xxxxxxxxxx; tim@xxxxxxx;
> > ian.jackson@xxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxx; jbeulich@xxxxxxxx;
> > samuel.thibault@xxxxxxxxxxxx; Daniel De Graaf
> > Subject: RE: [Xen-devel] [PATCH v4 00/14] Enable vTPM subsystem on TPM 2.0
> > 
> > On Thu, 22 Jan 2015, Xu, Quan wrote:
> > > > -----Original Message-----
> > > > From: xen-devel-bounces@xxxxxxxxxxxxx
> > > > [mailto:xen-devel-bounces@xxxxxxxxxxxxx] On Behalf Of Stefano
> > > > Stabellini
> > > > Sent: Wednesday, January 21, 2015 6:37 PM
> > > > To: Xu, Quan
> > > > Cc: keir@xxxxxxx; ian.campbell@xxxxxxxxxx;
> > > > stefano.stabellini@xxxxxxxxxxxxx; tim@xxxxxxx;
> > > > ian.jackson@xxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxx;
> > > > jbeulich@xxxxxxxx; samuel.thibault@xxxxxxxxxxxx; Daniel De Graaf
> > > > Subject: Re: [Xen-devel] [PATCH v4 00/14] Enable vTPM subsystem on
> > > > TPM 2.0
> > > >
> > > > On Wed, 21 Jan 2015, Xu, Quan wrote:
> > > > > > -----Original Message-----
> > > > > > From: Daniel De Graaf [mailto:dgdegra@xxxxxxxxxxxxx]
> > > > > > Sent: Wednesday, January 21, 2015 6:28 AM
> > > > > > To: Xu, Quan; xen-devel@xxxxxxxxxxxxx
> > > > > > Cc: ian.campbell@xxxxxxxxxx; ian.jackson@xxxxxxxxxxxxx;
> > > > > > jbeulich@xxxxxxxx; keir@xxxxxxx; tim@xxxxxxx;
> > > > > > stefano.stabellini@xxxxxxxxxxxxx; samuel.thibault@xxxxxxxxxxxx
> > > > > > Subject: Re: [PATCH v4 00/14] Enable vTPM subsystem on TPM 2.0
> > > > > >
> > > > > > On 01/15/2015 04:21 AM, Quan Xu wrote:
> > > > > > > This series of patch enable the virtual Trusted Platform
> > > > > > > Module
> > > > > > > (vTPM) subsystem for Xen on TPM 2.0.
> > > > > > >
> > > > > > > Noted, functionality for a virtual guest operating system (a
> > > > > > > DomU) is still TPM 1.2. The main modifcation is on
> > > > > > > vtpmmgr-stubdom. The challenge is that TPM 2.0 is not backward
> > compatible with TPM 1.2.
> > > > > > >
> > > > > >
> > > > > > Updates from v3 all look good, all patches in this series:
> > > > > >
> > > > > > Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> > > > > >
> > > > > > PS: If you need to re-post this in the future, you should add
> > > > > > that line below the signed-off-by on the unchanged patches, so
> > > > > > that it is clear to the other Xen maintainers that only the
> > > > > > changed/new patches need
> > > > my review.
> > > > > >
> > > > > > --
> > > > >
> > > > > Many thanks.
> > > > > For example:
> > > > >        Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> > > > >        Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> Right?
> > > >
> > > > That is correct.
> > >
> > > Stefano, Thanks.
> > > Now this series of patch were Acked-by Daniel De Graaf
> > > <dgdegra@xxxxxxxxxxxxx>. could you also Review them and give me some
> > comments or feedback? Thanks.
> > 
> > I am not sure if I am really the right person to give you feedback on it.
> > But I do trust Daniel's opinion on it.
> 
> Thanks Stefano. 
> Now Wei Liu is splitting off mini-os to a separate tree, could I send out v5 
> with
>    ..
>    Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx> 
>    Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
>    .. 
> Then, Daniel can merge these serious of patch to * staging branch. Or try to 
> send
> out the patches against the new mini-os tree.
> 
> Correct me, If the process is wrong.

I don't think that Daniel has commit access to the tree. Also given that
all your patches have been acked, you might not have to wait for Wei to
finish off splitting mini-os.

Ian? Wei? How do you want to go about this?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel