Re: [Xen-devel] [PATCH v2 10/12] xen/iommu: smmu: Check for duplicate stream IDs when registering master devices

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 27 Jan 2015, Julien Grall wrote:
> On 27/01/15 16:30, Stefano Stabellini wrote:
> > On Fri, 16 Jan 2015, Julien Grall wrote:
> >> From: Andreas Herrmann <andreas.herrmann@xxxxxxxxxxx>
> >>
> >> If DT information lists one stream ID twice for the master devices of
> >> an SMMU this can cause a multi match when stream ID matching is used.
> >> For stream ID indexing this might trigger an overwrite of an S2CR that
> >> is already in use.
> >>
> >> So better check for duplicates when DT information is parsed.
> >>
> >> Taken from the linux ML:
> >> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-January/226099.html
> >>
> >> Cc: Andreas Herrmann <herrmann.der.user@xxxxxxxxxxxxxx>
> >> Signed-off-by: Andreas Herrmann <andreas.herrmann@xxxxxxxxxxx>
> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > 
> > Why didn't you just take a more recent version of the Linux smmu driver?
> 
> The SMMU driver very is recent (see commit in the previous patch)...
> Just this patch has never reached upstream.

That is not good. It might be worth to wait for it to go upstream.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel