Re: [Xen-devel] [PATCH] tools/Makefile: fix qemu-xen-traditional build

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2015-01-26 at 11:05 +0000, Wei Liu wrote:
> On Mon, Jan 26, 2015 at 09:55:41AM +0000, Ian Campbell wrote:
> > On Sun, 2015-01-25 at 15:38 +0000, Wei Liu wrote:
> > > In d9740237a ("tools: unhook blktap1 from the build and remove all
> > > references to it"), one spot was left unchanged, which leads to failure
> > > in building qemu-xen-traditional.
> > 
> > Well spotted, which make invocation hits this path? make dist (what I
> > test) didn't.
> > 
> 
> make -C tools build.
> 
> > 
> > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > 
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

And applied.

> > 
> > Should we be worried that the -all- and -install- targets are similar
> > but not identical? Specifically one of them lack --extra-cflags?
> > 
> 
> Perhaps nobody ever provides EXTRA_CFLAGS_QEMU_TRADITIONAL so nobody
> ever trips over that.

Probably true, or at least those people who do use make dist etc.

> > Perhaps we should refactor those so the options are only given ones?
> > 
> 
> This is a good idea. I can do another patch later.

Thanks..



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel