Re: [Xen-devel] [PATCH 1/4] x86/HVM: replace plain number in hvm_combine_hw_exceptions()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.01.15 at 15:42, <tim@xxxxxxx> wrote:
> At 13:57 +0000 on 22 Jan (1421931437), Jan Beulich wrote:
>> While doing so also take care of #VE here (even if we don't make use of
>> it yet).
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> 
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -205,6 +205,16 @@ int hvm_event_needs_reinjection(uint8_t 
>>   */
>>  uint8_t hvm_combine_hw_exceptions(uint8_t vec1, uint8_t vec2)
>>  {
>> +    const unsigned int contributory_exceptions =
>> +        (1 << TRAP_divide_error) |
>> +        (1 << TRAP_invalid_tss) |
>> +        (1 << TRAP_no_segment) |
>> +        (1 << TRAP_stack_error) |
>> +        (1 << TRAP_gp_fault);
> 
> == 0x3c01, i.e. TRAP_page_fault has gone missing.  AFAICS that's
> correct, but please mention it in the patch description.

Since it's part of page_faults I don't think it has gone missing, but I'll
add an explaining sentence nevertheless.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel