Re: [Xen-devel] [RFC PATCH V2 2/8] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'

[Tim Deegan <tim@xxxxxxx>]

At 16:17 +0100 on 18 Jan (1421594275), Tamas K Lengyel wrote:
> The name of the ring still implies it is used only for memory accesses,
> which is no longer the case. It is also used to deliver variuos HVM events,
> thus the name "monitor" is more appropriate in this setting.
> 
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>

Renaming the ring seems good (again assuming everyone is happy about
making these API changes).  However I think you need to rework the
public header comment a bit more than just s/access/monitor/.  The
operation is to set up the event ring but almost all the comments is
about the access permissions system.  It needs a description that
would be useful to a developer who didn't already know how all thses
systems worked. :)

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel