Re: [Xen-devel] [PATCH RFC] pvh: set need_iommu early

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.01.15 at 21:53, <elena.ufimtseva@xxxxxxxxxx> wrote:

Apart from the issues with this submission that Kevin already
mentioned, please ...

> --- a/xen/arch/x86/domain_build.c
> +++ b/xen/arch/x86/domain_build.c
> @@ -1500,7 +1500,9 @@ int __init construct_dom0(
>  
>      if ( is_pvh_domain(d) )
>      {
> -        /* finally, fixup the page table, replacing mfns with pfns */
> +     d->need_iommu = 1;
> +
> +     /* finally, fixup the page table, replacing mfns with pfns */

... don't use hard tabs and ...

> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -154,7 +154,7 @@ void __hwdom_init iommu_hwdom_init(struct domain *d)
>          return;
>  
>      register_keyhandler('o', &iommu_p2m_table);
> -    d->need_iommu = !!iommu_dom0_strict;
> +    d->need_iommu |= !!iommu_dom0_strict;

... explain what this is needed for (considering that
iommu_dom0_strict gets forced to 1 for PVH).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel