Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.01.15 at 15:22, <julien.grall@xxxxxxxxxx> wrote:
> On 21/01/15 14:13, Jan Beulich wrote:
>>>>> On 21.01.15 at 13:13, <julien.grall@xxxxxxxxxx> wrote:
>>> iommu_dom0_strict is always set to 1 when IOMMU is used on ARM (see
>>> check_hwdom_reqs).
>>>
>>> Futhermore, we always share the page table with the processor, so we
>>> never need to populate the page table.
>> 
>> That's all far from obvious looking at the patch at hand. And you
>> can then only hope that these two "always" will always remain to
>> be that way.
> 
> Hence the suggested ASSERT on a previous mail. I could also add a
> comment in the code explaining the ASSERT().

Yes please, for both parts.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel