Re: [Xen-devel] [PATCH OSSTEST v4 13/13] Debian: create boot.scr.nat when installing Xen on u-boot.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v4 13/13] Debian: create boot.scr.nat when 
installing Xen on u-boot."):
> This boots the kernel we've build natively, where boot.xen boots Xen
> and boot.deb boots the original Debian kernel.
> 
> Sometimes convenient when debugging issues.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
> v4: New patch
> ---
>  Osstest/Debian.pm | 40 ++++++++++++++++++++++++++++++++++------
>  1 file changed, 34 insertions(+), 6 deletions(-)
> 
> diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
> index 8169c01..20485e2 100644
> --- a/Osstest/Debian.pm
> +++ b/Osstest/Debian.pm
> @@ -136,18 +136,32 @@ sub setupboot_uboot ($$$) {
>  
>       my $root= target_guest_lv_name($ho,"root");
>       my $rootdelay=get_host_property($ho, "rootdelay");
> +     my $natcons=get_host_native_linux_console($ho);

The coding style here (missing spaces to rhs of =) is getting worse.
The existing code is inconsistent between ` = ' and `= ' but I think
adding `=' too is not helping...

> +     # Native specific kernel options
> +
> +     my @natkopt = @kopt;
> +     push @natkopt, "console=$natcons" unless $natcons eq "NONE";

Ah I think this answers my question about native console, from
earlier.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel