Re: [Xen-devel] [PATCH] tools: generate systemd service files only when systemd is available

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2015-01-20 at 11:47 +0000, Wei Liu wrote:
> Though that's not in any way harmful but it is on the other hand not
> very useful.

It's not 100% clear in the docs that you can call this macro twice, but
it definitely doesn't say you can't so I'd assume it was OK:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> Please rerun autogen.sh after applying this patch.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
>  tools/configure.ac | 26 ++++++++++++++++----------
>  1 file changed, 16 insertions(+), 10 deletions(-)
> 
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 113285d..850ba23 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -12,16 +12,6 @@ hotplug/Linux/init.d/sysconfig.xencommons
>  hotplug/Linux/init.d/xen-watchdog
>  hotplug/Linux/init.d/xencommons
>  hotplug/Linux/init.d/xendomains
> -hotplug/Linux/systemd/proc-xen.mount
> -hotplug/Linux/systemd/var-lib-xenstored.mount
> -hotplug/Linux/systemd/xen-init-dom0.service
> -hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service
> -hotplug/Linux/systemd/xen-watchdog.service
> -hotplug/Linux/systemd/xenconsoled.service
> -hotplug/Linux/systemd/xendomains.service
> -hotplug/Linux/systemd/xenstored.service
> -hotplug/Linux/systemd/xenstored.socket
> -hotplug/Linux/systemd/xenstored_ro.socket
>  hotplug/Linux/vif-setup
>  hotplug/Linux/xen-backend.rules
>  hotplug/Linux/xen-hotplug-common.sh
> @@ -386,5 +376,21 @@ AC_SUBST(LIBNL3_CFLAGS)
>  fi # ! $rump
>  
>  AX_AVAILABLE_SYSTEMD()
> +
> +AS_IF([test "x$systemd" = "xy"], [
> +    AC_CONFIG_FILES([
> +    hotplug/Linux/systemd/proc-xen.mount
> +    hotplug/Linux/systemd/var-lib-xenstored.mount
> +    hotplug/Linux/systemd/xen-init-dom0.service
> +    hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service
> +    hotplug/Linux/systemd/xen-watchdog.service
> +    hotplug/Linux/systemd/xenconsoled.service
> +    hotplug/Linux/systemd/xendomains.service
> +    hotplug/Linux/systemd/xenstored.service
> +    hotplug/Linux/systemd/xenstored.socket
> +    hotplug/Linux/systemd/xenstored_ro.socket
> +    ])
> +])
> +
>  AC_OUTPUT()
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel