[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/4] xen/domain: Introduce domain_max_vcpus() helper and implement per arch



>>> On 19.01.15 at 12:21, <andrew.cooper3@xxxxxxxxxx> wrote:
> +unsigned int domain_max_vcpus(const struct domain *d)
> +{
> +    if ( is_hvm_domain(d) )
> +        return HVM_MAX_VCPUS;
> +    else
> +        return MAX_VIRT_CPUS;
> +}

Together with making this inline, I think such things are better coded
using the conditional operator (or at the very least without the
redundant "else").

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.