[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 10/14] xen/gntdev: convert priv->lock to a mutex

On Mon, 19 Jan 2015, David Vrabel wrote:
> On 19/01/15 17:49, Stefano Stabellini wrote:
> > On Mon, 19 Jan 2015, David Vrabel wrote:
> >> Unmapping may require sleeping and we unmap while holding priv->lock, so
> >> convert it to a mutex.
> > 
> > It would be useful to list in the commit message the operations that
> > might sleep and are currently called with the spinlock held.
> It's the next patch that introduces the sleeping, when we wait on the
> completion for the async grant unmap to complete.

Ah! Makes sense.
One thing to keep in mind is that mutex_lock can introduce a sleep
itself. We need to make sure that all the call sites in gntdev.c are OK
with it.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.