[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] re-order struct domain fields

On Mon, 2015-01-19 at 15:42 +0000, Jan Beulich wrote:
> ... to reduce padding holes.
> I also wonder whether having independent spin locks side by side is
> really a good thing cache-line-bouncing-wise.

AIUI the general wisdom is to put each spinlock next to the data it
protects (I suppose on the assumption that after acquiring the lock you
will next touch that data).

Is the problem is that the domain_lock doesn't actually protect anything
in this struct since it is a more umbrella lock, so there is nothing to
put next to it?

You could move either it or the page lock below all the page counts


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.