Re: [Xen-devel] [PATCH 2/3] xen-sndfront: switch to the v2 driver

[Oleksandr Dmytryshyn <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx>]

On Mon, Jan 19, 2015 at 12:57 PM, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> On 19/01/15 08:19, Oleksandr Dmytryshyn wrote:
>> From: Iurii Konovalenko <iurii.konovalenko@xxxxxxxxxxxxxxx>
>>
>> Now this driver registers an virtual sound card
>> and sends an PCM streams to the backend driver.
>> Backend driver is an user-space application and
>> uses ALSA with dmix plugin to play audio.
>>
> [...]
>>  struct sndif_request_open {
>> -     unsigned int dev_num;
>> -     unsigned int card_num;
>> -     unsigned int dev_type;
>> +     struct alsa_hwparams hwparams;
>
> Don't put ALSA specific structures in the ABI.  The protocol needs to be
> suitable for frontend drivers that aren't ALSA.
This structure is defined upper in this file.
I'll rename this structure in the next patch-set.

> David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel