Re: [Xen-devel] [PATCH v1 2/3] xen/arm: Add new driver for R-Car Gen2 UART

[Oleksandr Tyshchenko <oleksandr.tyshchenko@xxxxxxxxxxxxxxx>]

On Fri, Jan 16, 2015 at 3:19 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

Hi Iurii,

Hi Julien

On 16/01/15 12:50, Iurii Konovalenko wrote:
> +static int __init rcar2_uart_init(struct dt_device_node *dev,
> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âconst void *data)
> +{
> +Â Â const char *config = data;
> +Â Â struct rcar2_uart *uart;
> +Â Â int res;
> +Â Â u64 addr, size;
> +
> +Â Â if ( strcmp(config, "") )
> +Â Â Â Â printk("WARNING: UART configuration is not supported\n");
> +
> +Â Â uart = &rcar2_com;
> +
> +  uart->clock_hz = SCIF_CLK_FREQ;
> +  uart->baud   = BAUD_AUTO;
> +Â Â uart->data_bits = 8;
> +  uart->parity  = PARITY_NONE;
> +Â Â uart->stop_bits = 1;
> +
> +Â Â res = dt_device_get_address(dev, 0, &addr, &size);
> +Â Â if ( res )
> +Â Â {
> +Â Â Â Â printk("rcar2-uart: Unable to retrieve the base"
> +Â Â Â Â Â Â Â Â Â Â Â" address of the UART\n");
> +Â Â Â Â return res;
> +Â Â }
> +
> +Â Â uart->regs = ioremap_attr(addr, size, PAGE_HYPERVISOR_NOCACHE);

Please use ioremap_nocache

ok

--
Julien Grall

--

Oleksandr Tyshchenko | Embedded Dev
GlobalLogic
www.globallogic.com

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel