Re: [Xen-devel] [PATCH v2 06/12] xen/arm: Introduce a generic way to describe device

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Jan,

On 16/01/15 14:59, Jan Beulich wrote:
>>>> On 16.01.15 at 15:24, <julien.grall@xxxxxxxxxx> wrote:
>> ---
>>  xen/common/device.c           | 21 +++++++++++++++++++++
>>  xen/common/device_tree.c      |  3 +++
> 
> Is there a Makefile change missing here?

No. The file common/device.c should not be there. I drop for my tree but
somehow it stay in the patch. Sorry.

[..]

>> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
>> index 34a1b9e..d1c716f 100644
>> --- a/xen/common/device_tree.c
>> +++ b/xen/common/device_tree.c
>> @@ -1454,6 +1454,9 @@ static unsigned long __init unflatten_dt_node(const 
>> void *fdt,
>>              ((char *)pp->value)[sz - 1] = 0;
>>              dt_dprintk("fixed up name for %s -> %s\n", pathp,
>>                         (char *)pp->value);
>> +            /* Generic device initialization */
>> +            np->dev.type = DEV_DT;
>> +            np->dev.of_node = np;
> 
> Why is this not device_initialize(&np->dev, DEV_DT)?

Because the file containing the function has been dropped. It's a
left-over of the previous version.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel