Re: [Xen-devel] [PATCH for-4.5 v7 3/7] vmware: Add VMware provided include files.

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 01/15/15 11:46, Jan Beulich wrote:
>>>> On 02.10.14 at 23:30, <dslutz@xxxxxxxxxxx> wrote:
>> These 2 files: backdoor_def.h and guest_msg_def.h come from:
>>
>> http://packages.vmware.com/tools/esx/3.5latest/rhel4/SRPMS/index.html 
>>  open-vm-tools-kmod-7.4.8-396269.423167.src.rpm
>>   open-vm-tools-kmod-7.4.8.tar.gz
>>    vmhgfs/backdoor_def.h
>>    vmhgfs/guest_msg_def.h
>>
>> and are unchanged.
> 
> Either the description is wrong, or the patch is stale - there's no
> guest_msg_def.h here.
> 

The commit message is stale.  Missed adjusting for removal of VMware
rpc stuff.  Will Fix.

>> Added the badly named include file includeCheck.h also.  It only
>> has comments and is provided so that backdoor_def.h and
>> guest_msg_def.h can be used without change.
> 
> In which case I'd say a file with a single comment line in it would
> suffice. Such a comment is hardly copyrightable...
> 

Ok, Will make it a single line comment.

   -Don Slutz

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel