Re: [Xen-devel] [PATCH] x86/minios: Remove more vestigial remnants of SUPERVISOR_MODE_KERNEL

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Andrew Cooper, le Thu 15 Jan 2015 19:07:47 +0000, a écrit :
> MiniOS has never advertised support for supervisor_mode_kernel, and the
> feature was only ever implemented for 32bit Xen.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Tim Deegan <tim@xxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> CC: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> ---
>  extras/mini-os/arch/x86/x86_64.S |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/extras/mini-os/arch/x86/x86_64.S 
> b/extras/mini-os/arch/x86/x86_64.S
> index df3469e..72921b1 100644
> --- a/extras/mini-os/arch/x86/x86_64.S
> +++ b/extras/mini-os/arch/x86/x86_64.S
> @@ -125,13 +125,10 @@ KERNEL_CS_MASK = 0xfc
>       testl $NMI_MASK,2*8(%rsp)
>       jnz   2f
>  
> -     testb $1,(xen_features+XENFEAT_supervisor_mode_kernel)
> -     jnz   1f
> -
>       /* Direct iret to kernel space. Correct CS and SS. */
>       orb   $3,1*8(%rsp)
>       orb   $3,4*8(%rsp)
> -1:   iretq
> +     iretq
>  
>  2:   /* Slow iret via hypervisor. */
>       andl  $~NMI_MASK, 16(%rsp)
> -- 
> 1.7.10.4
> 

-- 
Samuel
>       dvips -o $@ $<     
Faut faire gffe de pas te couper avec ton truc, t'as mis des ciseaux ($<)
partout :))
-+- Dom in Guide du linuxien pervers - "J'aime pas les Makefile !" -+-

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel