Re: [Xen-devel] [PATCH v3 03/19] libxc: allocate memory with vNUMA information for PV guest

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jan 14, 2015 at 10:58:08AM +0000, Andrew Cooper wrote:
[...]
> >>> +                         &dom->p2m_host[pfn_base+j]);
> >>> +
> >>> +                if ( rc )
> >>> +                {
> >>> +                    if ( dom->vnode_to_pnode[i] != XC_VNUMA_NO_NODE )
> >>> +                        xc_dom_panic(dom->xch, XC_INTERNAL_ERROR,
> >>> +                                     "%s: fail to allocate 
> >>> 0x%"PRIx64"/0x%"PRIpfn" pages (v=%d, p=%d)\n",
> >>> +                                     __FUNCTION__, pages, 
> >>> dom->total_pages, i,
> >>> +                                     dom->vnode_to_pnode[i]);
> >> "failed to allocate"
> >>
> > Fixed.
> >
> >> I am not sure the total number of pages is useful here, especially as
> >> you don't know how many pages have successfully been allocated first.
> >>
> > Are you suggesting we don't print any number of print more numbers?
> 
> I am not suggesting that you don't print numbers.  "pages" is useful to
> know in the error message, but "d->total_pages" is not, as you don't
> know how many successful allocations have occurred before, and the total
> allocated memory so far.
> 

OK. Don't print dom->total_pages then. :-)

Wei.

> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel