Re: [Xen-devel] [libvirt] [PATCH V4 1/3] Introduce support for parsing/formatting Xen xl config format

[Jim Fehlig <jfehlig@xxxxxxxx>]

Eric Blake wrote:
> On 01/13/2015 08:53 AM, Jim Fehlig wrote:
>   
>> Introduce a parser/formatter for the xl config format.  Since the
>> deprecation of xm/xend, the VM config file format has diverged as
>> new features are added to libxl.  This patch adds support for parsing
>> and formating the xl config format.  It supports the existing xm config
>> format, plus adds support for spice graphics and xl disk config syntax.
>>
>>     
>
>   
>> xl disk config is parsed with the help of xlu_disk_parse() from
>> libxlutil, libxl's utility library.  Although the library exists
>> in all Xen versions supported by the libxl virt driver, only
>> recently has the corresponding header file been included.  A check
>> for the header is done in configure.ac.  If not found, xlu_disk_parse()
>> is declared externally.
>>
>> Signed-off-by: Kiarie Kahurani <davidkiarie4@xxxxxxxxx>
>> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
>> ---
>> +++ b/src/Makefile.am
>> @@ -1005,6 +1005,10 @@ XENCONFIG_SOURCES =                                   
>>         \
>>              xenconfig/xen_common.c xenconfig/xen_common.h   \
>>              xenconfig/xen_sxpr.c xenconfig/xen_sxpr.h       \
>>              xenconfig/xen_xm.c xenconfig/xen_xm.h
>> +if WITH_LIBXL
>> +XENCONFIG_SOURCES +=                                                \
>> +            xenconfig/xen_xl.c xenconfig/xen_xl.h
>> +endif WITH_LIBXL
>>     
>
> Missing an EXTRA_DIST listing to ensure these two files are part of a
> tarball even when configure does not build libxl sources (that is, make
> sure 'make distcheck' will not fail if configured on a machine without
> libxl support).
>   

Several of the tests fail on the old distro I'm testing on, which causes
'make distcheck' to fail.  But I assumed I could simulate it on a newer
distro with 'configure --without-libxl', yet 'make distcheck' succeeds
and the files are included in the tarball.  Are you seeing a failure on
RHEL5?

Regards,
Jim


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel