Re: [Xen-devel] [PATCH v3 05/19] libxl: add vmemrange to libxl__domain_build_state

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jan 13, 2015 at 05:02:10PM +0000, Ian Jackson wrote:
> Wei Liu writes ("[PATCH v3 05/19] libxl: add vmemrange to 
> libxl__domain_build_state"):
> > A vnode consists of one or more vmemranges (virtual memory range).  One
> > example of multiple vmemranges is that there is a hole in one vnode.
> 
> I'm finding this series a bit oddly structured.  This patch, for
> example, just introduces some new fields to an internal state struct -
> but these fields are not initialised, set, or read.
> 

The new fields (and other existing fields) are initialised to zero in
initiate_domain_create, that's why it doesn't need to be explicitly
initialised.

These new fields are accessed in the next patch. I can either explicitly
say so in commit log or squash this patch with the next one. Which way
do you prefer?

TBH I don't think this patch and next one should be squashed into one
patch.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel