Re: [Xen-devel] [PATCH v3 18/19] libxlutil: nested list support

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH v3 18/19] libxlutil: nested list support"):
> This is done with three major changes:
> 1. Rework internal representation of setting.
> 2. Extend grammar of parser.
> 3. Introduce new APIs.

This commit message is very brief.  For example, under the heading of
`Rework internal representation of setting' I would expect a clear
description of every formulaic change.

Also, I think would be much easier to review if split up into 3 parts,
which from the description above ought to be doable without trouble.

AFAICT from your changes, the API is not backward compatible.  ICBW,
but if I'm right that's not acceptable I'm afraid, even in libxlu.

> Previous APIs work as before.

That can't be right because you have to at least specify how they deal
with the additional config file syntax.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel