Re: [Xen-devel] [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-12-15 at 00:59 +0100, Samuel Thibault wrote:
> Martin Lucina, le Thu 11 Dec 2014 13:10:00 +0100, a Ãcrit :
> > I've done this in the updated patch, take a look and let me know what you
> > think.
> 
> I like that :)
> 
> > From 3880f59159bf0a05b47b6e723091b1e7e4fb6814 Mon Sep 17 00:00:00 2001
> > From: Martin Lucina <martin@xxxxxxxxxx>
> > Date: Thu, 4 Dec 2014 14:33:53 +0100
> > Subject: [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx
> > 
> > In network_rx() we must push the same amount of requests back onto the
> > ring in the second loop that we consumed in the first loop. Otherwise
> > the ring will eventually starve itself of free request slots and no
> > packets will be delivered.
> > 
> > Further, we make the HAVE_LIBC codepath clearer to follow by removing
> > the "some" variable from the for loop initialisation and conditions.
> > 
> > Signed-off-by: Martin Lucina <martin@xxxxxxxxxx>
> 
> Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

Applied, thanks. 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel