Re: [Xen-devel] [PATCH] common/memory: fix an XSM error path

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 01/12/2015 03:21 AM, Jan Beulich wrote:
> XENMEM_{in,de}crease_reservation as well as XENMEM_populate_physmap
> return the extent at which failure was detected, not error indicators.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
(though I don't think my ack is technically required here)

> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -747,11 +747,10 @@ long do_memory_op(unsigned long cmd, XEN
>               return start_extent;
>           args.domain = d;
>
> -        rc = xsm_memory_adjust_reservation(XSM_TARGET, current->domain, d);
> -        if ( rc )
> +        if ( xsm_memory_adjust_reservation(XSM_TARGET, current->domain, d) )
>           {
>               rcu_unlock_domain(d);
> -            return rc;
> +            return start_extent;
>           }
>
>           switch ( op )

--
Daniel De Graaf
National Security Agency

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel