Re: [Xen-devel] [PATCH v2 16/21] xen/passthrough: iommu_deassign_device_dt: By default reassign device to nobody

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Stefano,

Sorry for the very late answer on this patch.

On 06/08/14 17:23, Stefano Stabellini wrote:
>> diff --git a/xen/drivers/passthrough/device_tree.c 
>> b/xen/drivers/passthrough/device_tree.c
>> index 45d4a59..f8affa0 100644
>> --- a/xen/drivers/passthrough/device_tree.c
>> +++ b/xen/drivers/passthrough/device_tree.c
>> @@ -75,14 +75,12 @@ int iommu_deassign_dt_device(struct domain *d, struct 
>> dt_device_node *dev)
>>  
>>      spin_lock(&dtdevs_lock);
>>  
>> -    rc = hd->platform_ops->reassign_dt_device(d, hardware_domain, dev);
>> +    rc = hd->platform_ops->reassign_dt_device(d, NULL, dev);
>>      if ( rc )
>>          goto fail;
> 
> At this point, isn't it better just to call arm_smmu_detach_dev?

That would mean introducing an new callback in structure. I would prefer
modify reassign_dt_device rather than adding a new one.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel