[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/misc: Cleanup makefile

On Thu, Jan 08, 2015 at 01:34:22PM +0000, Andrew Cooper wrote:
> The existing makefile was awkward with needing to express conditional
> inclusion for both the build and install rules, and contained both split and
> unsplit long lines.
> The INSTALL_* rules now contain the conditional inclusion information, while
> the TARGET_* rules generate the build list from the complete install list,
> less the minority of scripts which simply need copying into place.  Comments
> are introduces to aid clarity.
> In addition, collect the CFLAGS expressions, remove the unreferenced and empty
> HDRS list, and restrict the libxc internals build fix to the offending
> binaries.
> No functional change as a result of this patch, but it is rather more simple
> to add or remove utilities.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>

This looks correct to me.

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.