Re: [Xen-devel] [PATCH v2 2/5] vTPM: limit libxl__add_vtpms() function to para virtual machine

["Xu, Quan" <quan.xu@xxxxxxxxx>]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> Sent: Tuesday, January 06, 2015 5:45 PM
> To: Xu, Quan
> Cc: Wei Liu; xen-devel@xxxxxxxxxxxxx; ian.jackson@xxxxxxxxxxxxx;
> stefano.stabellini@xxxxxxxxxxxxx; ian.campbell@xxxxxxxxxx
> Subject: Re: [PATCH v2 2/5] vTPM: limit libxl__add_vtpms() function to para
> virtual machine
> 
> On Tue, Jan 06, 2015 at 02:17:36AM +0000, Xu, Quan wrote:
> >
> >
> > > -----Original Message-----
> > > From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> > > Sent: Monday, January 05, 2015 8:53 PM
> > > To: Xu, Quan
> > > Cc: xen-devel@xxxxxxxxxxxxx; ian.jackson@xxxxxxxxxxxxx;
> > > stefano.stabellini@xxxxxxxxxxxxx; ian.campbell@xxxxxxxxxx;
> > > wei.liu2@xxxxxxxxxx
> > > Subject: Re: [PATCH v2 2/5] vTPM: limit libxl__add_vtpms() function
> > > to para virtual machine
> > >
> > > On Tue, Dec 30, 2014 at 11:45:02PM -0500, Quan Xu wrote:
> > > > Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> > > > ---
> > > >  tools/libxl/libxl_create.c | 5 +++--
> > > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/tools/libxl/libxl_create.c
> > > > b/tools/libxl/libxl_create.c index b1ff5ae..0a09925 100644
> > > > --- a/tools/libxl/libxl_create.c
> > > > +++ b/tools/libxl/libxl_create.c
> > > > @@ -1358,8 +1358,9 @@ static void
> > > > domcreate_attach_vtpms(libxl__egc
> > > *egc,
> > > >         goto error_out;
> > > >     }
> > > >
> > > > -    /* Plug vtpm devices */
> > > > -   if (d_config->num_vtpms > 0) {
> > > > +   /* Plug vtpm devices for para virtual domain*/
> > > > +   if (d_config->num_vtpms > 0 &&
> > > > +       d_config->b_info.type == LIBXL_DOMAIN_TYPE_PV) {
> > >
> > > It's unclear to me why you stub out HVM domain. You need to state
> > > your reasoning in comment and commit log. :-/
> >
> > In brief, it is different to plug vtpm device for HVM/PV domain. I will try 
> > to
> describe more detailed in next v3. Thanks Wei.
> >
> 
> I got that idea when I read your later patch. But stubbing out PV here is
> wrong. Essentially this patch introduces a functional regression by itself
> because now you can't add vtpms for PV. I doubt that you will still need this
> patch in your next round.  See my reply to patch 4/5.
> 

Okay, I will reply with that email directly..
Quan 

> Wei.
> 
> > Thanks
> > Quan Xu
> > >
> > > Wei.
> > >
> > > >         /* Attach vtpms */
> > > >         libxl__multidev_begin(ao, &dcs->multidev);
> > > >         dcs->multidev.callback = domcreate_attach_pci;
> > > > --
> > > > 1.8.3.2

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel