Re: [Xen-devel] [PATCH 3/4] tools: libxl: code preparation for MBM

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Mon, Jan 05, 2015 at 12:25:05PM +0000, Wei Liu wrote:
> On Tue, Dec 23, 2014 at 04:54:38PM +0800, Chao Peng wrote:
> [...]
> > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > index 3737c7e..f4534ec 100644
> > --- a/tools/libxl/xl_cmdimpl.c
> > +++ b/tools/libxl/xl_cmdimpl.c
> > @@ -7845,12 +7845,13 @@ out:
> >  }
> >  
> >  #ifdef LIBXL_HAVE_PSR_CMT
> > -static void psr_cmt_print_domain_cache_occupancy(libxl_dominfo *dominfo,
> > +static void psr_cmt_print_domain_l3_info(libxl_dominfo *dominfo,
> > +                                                    libxl_psr_cmt_type 
> > type,
> >                                                      uint32_t nr_sockets)
> 
> Indentation.
> 
> >  {
> >      char *domain_name;
> >      uint32_t socketid;
> > -    uint32_t l3_cache_occupancy;
> > +    uint32_t data;
> >  
> >      if (!libxl_psr_cmt_domain_attached(ctx, dominfo->domid))
> >          return;
> > @@ -7860,15 +7861,21 @@ static void 
> > psr_cmt_print_domain_cache_occupancy(libxl_dominfo *dominfo,
> >      free(domain_name);
> >  
> >      for (socketid = 0; socketid < nr_sockets; socketid++) {
> > -        if ( !libxl_psr_cmt_get_cache_occupancy(ctx, dominfo->domid,
> > -                 socketid, &l3_cache_occupancy) )
> > -            printf("%13u KB", l3_cache_occupancy);
> > +        switch (type) {
> > +        case LIBXL_PSR_CMT_TYPE_CACHE_OCCUPANCY:
> > +            if ( !libxl_psr_cmt_get_cache_occupancy(ctx, dominfo->domid,
> > +                 socketid, &data) )
> > +                printf("%13u KB", data);
> > +            break;
> > +        default:
> > +            return;
> > +        }
> >      }
> >  
> >      printf("\n");
> >  }
> >  
> > -static int psr_cmt_show_cache_occupancy(uint32_t domid)
> > +static int psr_cmt_show_l3_info(libxl_psr_cmt_type type, uint32_t domid)
> >  {
> >      uint32_t i, socketid, nr_sockets, total_rmid;
> >      uint32_t l3_cache_size;
> > @@ -7904,18 +7911,22 @@ static int psr_cmt_show_cache_occupancy(uint32_t 
> > domid)
> >          printf("%14s %d", "Socket", socketid);
> >      printf("\n");
> >  
> > -    /* Total L3 cache size */
> > -    printf("%-46s", "Total L3 Cache Size");
> > -    for (socketid = 0; socketid < nr_sockets; socketid++) {
> > -        rc = libxl_psr_cmt_get_l3_cache_size(ctx, socketid, 
> > &l3_cache_size);
> > -        if (rc < 0) {
> > -            fprintf(stderr, "Failed to get system l3 cache size for 
> > socket:%d\n",
> > -                            socketid);
> > -            return -1;
> > -        }
> > -        printf("%13u KB", l3_cache_size);
> > +    if ( type == LIBXL_PSR_CMT_TYPE_CACHE_OCCUPANCY ) {
> 
> Coding style, no space after "(" and before ")".
> 
> I missed this issue when I reviewed your previous patches.  You can fix
> this style problem here while you're at it.
Sure, I will fix them all.
Thanks.

Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel