Re: [Xen-devel] [PATCH] xen: arm: correct off-by-one error in consider_modules

[Ian Campbell <ijc@xxxxxxxxxxxxxx>]

On Mon, 2014-12-22 at 11:54 +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 21/12/2014 12:18, Ian Campbell wrote:
> > By iterating up to <= mi->nr_mods we are running off the end of the boot
> > modules, but more importantly it causes us to then skip the first FDT 
> > reserved
> > region, meaning we might clobber it.
> 
> Oops. Good catch!
> 
> OOI, how did you find it?

U-boot on Jetson was locating the PSCI handling code at the top of RAM
and reserving it in the DT, but Xen was still relocating itself over it,
causing secondary CPU bringup to hang the board.

(This is an experimental u-boot, so it doesn't actually enforce the
security of the PSCI region yet, if it did I'd have expected a fault on
relocation instead of a hang on CPU up).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel