Re: [Xen-devel] [PATCH v5 2/9] xen: introduce SHUTDOWN_soft_reset shutdown reason

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.12.14 at 14:45, <vkuznets@xxxxxxxxxx> wrote:
> --- a/xen/common/shutdown.c
> +++ b/xen/common/shutdown.c
> @@ -71,6 +71,13 @@ void hwdom_shutdown(u8 reason)
>          break; /* not reached */
>      }
>  
> +    case SHUTDOWN_soft_reset:
> +    {
> +        printk("Domain 0 did soft reset but it is unsupported, 
> rebooting.\n");

Please shorten the message by e.g. dropping "did" and "but it is",
and please also don't add pointless braces around this code (no
matter that other code above/below does so - actually the whole
function could use an overhaul, dropping these braces and
replacing the mention of "Domain 0" with either "Hardware domain"
or "Dom%d" using hwdom's correct ID).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel