[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 for-4.5 1/3] python/xc: Fix multiple issues in pyflask_context_to_sid()



On Wed, 2014-12-10 at 12:13 -0500, Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 09, 2014 at 04:43:22PM +0000, Andrew Cooper wrote:
> > The error handling from a failed memory allocation should return
> > PyErr_SetFromErrno(xc_error_obj); rather than simply calling it and 
> > continuing
> > to the memcpy() below, with the dest pointer being NULL.
> > 
> > Coverity also complains about passing a non-NUL terminated string to
> > xc_flask_context_to_sid().  xc_flask_context_to_sid() doesn't actually take 
> > a
> > NUL terminated string, but it does take a char* which, in context, used to 
> > be
> > a string, which is why Coverity complains.
> > 
> > One solution would be to use strdup(ctx) which is simpler than a
> > strlen()/malloc()/memcpy() combo, which would result in a NUL-terminated
> > string being used with xc_flask_context_to_sid().
> > 
> > However, ctx is strictly an input to the hypercall and is not mutated along
> > the way.  Both these issues can be fixed, and the error logic simplified, by
> > not duplicating ctx in the first place.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Coverity-IDs: 1055305 1055721
> > Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> > CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> > CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> > CC: Xen Coverity Team <coverity@xxxxxxx>
> > 
> > ---
> > v2: Expand the commit message.  No code change
> 
> Thank you.
> 
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 

Applied.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.