Re: [Xen-devel] [PATCH 00/12] Enable vTPM subsystem on TPM 2.0

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 12/14/2014 07:09 AM, Quan Xu wrote:
> This series of patch enable the virtual Trusted Platform Module (vTPM)
> subsystem for Xen on TPM 2.0.
>
> Noted, functionality for a virtual guest operating system (a DomU) is still
> TPM 1.2. The main modifcation is on vtpmmgr-stubdom. The challenge is that
> TPM 2.0 is not backward compatibility with TPM 1.2.
This series looks good.  Other than a minor comment on #9, my only concern is
the use of bind/unbind instead of seal/unseal (mentioned in my reply to #11,
but it really applies to the series as a whole).  Changing the data structures
to support hashes, authdata, and other measurements larger than 20 bytes is
probably best done sooner so that the management commands can be changed before
much infrastructure is built using the existing ones, but it doesn't have to be
done as part of the introduction of TPM2 support.

Due to the holidays, I will not be able to review further patches until January.

--
Daniel De Graaf
National Security Agency

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel