[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 22/27] ts-bench-hostcmp-host-prep: new script



On Thu, 2014-12-11 at 12:32 +0000, Wei Liu wrote:
> On Wed, Dec 10, 2014 at 07:11:52PM +0100, Dario Faggioli wrote:

> > +  logm("Will run the benchmark on host with: $bcpus vcpus and $bmem MB 
> > RAM");
> > +
> > +  my $kernver= get_runvar('kernel_ver',$r{'kernbuildjob'});
> > +  my $kopt= "maxcpus=$bcpus mem=$bmem" . "M";
> > +
> > +  if ($ho->{Flags}{'need-uboot-bootscr'}) {
> > +      $bl= setupboot_uboot($ho,$kernver,undef,$kopt);
> > +  } elsif ($ho->{Suite} =~ m/lenny/) {
> > +      $bl= setupboot_grub1($ho,$kernver,undef,$kopt);
> > +  } else {
> > +      $bl= setupboot_grub2($ho,$kernver,undef,$kopt);
> > +  }
> > +
> > +  $bootkern= $bl->{PreFinalUpdate}();
> > +  $bl->{UpdateConfig}($ho);
> > +
> > +  $bootkern= $bl->{GetBootKern}();
> > +  logm("$ho->{Name} will reboot on kernel $bootkern with '$kopt' as 
> > options");
> 
> Can you refactor debian_setup_boot to achieve your goal?
> 
This happens in patch 23, at least to some extent. :-)

BTW, that patch came out without a changelog, so sorry again for that.

I can see if I can merge the parts of these patches that play with
debian_setup_boot into something that makes sense for both this and the
other patch's purposes.

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.