Re: [Xen-devel] [PATCH 09/27] ts-unixbench-reslts: process and plot bench results

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Dec 11, 2014 at 02:11:44PM +0100, Dario Faggioli wrote:
[...]
> > > +sub unixbench_plot_results ($$$) {
> > > +  my ($dataf,$num_cols,$pfile)= @_;
> > > +  my $h= new IO::File "> $pfile.gp" or die "$!";
> > > +
> > > +  printf $h <<EOF;
> > > +set terminal png enhanced font 
> > > "/usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.ttf" 8 size 800,600
> > > +set output '$pfile.png'
> > > +set title 'Unixbench INDEXes for $flight.$job'
> > > +set key outside center top horizontal noreverse noenhanced autotitles 
> > > nobox
> > > +set xtics mirror rotate by -45 out
> > > +set style data histogram
> > > +set style histogram cluster gap 1
> > > +set style fill solid border lt -1
> > > +set boxwidth 1 absolute
> > > +set bmargin 13
> > > +set rmargin 14
> > > +SKIP_COL=1
> > > +NCOL=$num_cols
> > > +HWIDTH=1.0/(NCOL+1.0)
> > > +plot for [c=SKIP_COL+1:SKIP_COL+NCOL] '$dataf' using c:xtic(1) with 
> > > histograms title columnhead, \\
> > > +        for [c=SKIP_COL+1:SKIP_COL+NCOL]'' every ::1 using 0:c:c with 
> > > labels notitle offset first 
> > > -HWIDTH*(NCOL/2.0)+HWIDTH/2.0+(c-(SKIP_COL+1))*HWIDTH, character 2 rotate 
> > > by 90
> > > +EOF
> > > +  close($h);
> > > +
> > > +  my $gp= can_run('gnuplot') or return;
> > 
> > Need to install gnuplot before hand?
> > 
> Well, this is the OSSTest controller, not the target host, guest or
> anything, so I'd need to install it by some perl equivalent of
> 'system("apt-get install gnuplot") (or whatever Perl offers to run
> system commands).
> 

Ah, the controller, OK...

> I haven't found many examples of executing commands on the controller in
> current OSSTest codebase, and I'm not sure whether that is a good idea
> and/or a strong requirement here... Again, let's see what others think.
> 
> > > +  my ($ok,$err)= run( command => "$gp $pfile.gp", verbose => 1 );
> > > +  logm("WARNING: plotting file with \"$err\"") unless $ok;
> > 
> > Fail the test case instead of issuing a warning?
> > 
> You think? Well, the benchmark(s) did run, and produced results that we
> can analyze in many way other than plotting, either inside OSSTest
> (adding the logic for that, of course) or outside of it, so I wouldn't
> call this a 'failure'.
> 

Since gnuplot runs on controller this point becomes moot.

> Perhaps I should distinguish between the cases where gnuplot is just not
> there, in which case I really would continue just issuing warnings, from
> the case where the plotting command ran and failed, in which cased I
> agree, we should fail the test... What do you think?
> 

Make sense.

Wei.

> Thanks and Regards,
> Dario
> 
> -- 
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel