Re: [Xen-devel] [PATCH OSSTEST] Add basic PVH flights.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-12-10 at 14:03 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH OSSTEST] Add basic PVH flights."):
> > On Wed, 2014-12-10 at 13:56 +0000, Ian Jackson wrote:
> > > This should probably be
> > > 
> > >   +       $cfg =~ s/^pvh\b.*//mg;
> > > 
> > > unless you deliberately intend to strip out any other phv-related
> > > settings which xen-create-image might put there ?
> > 
> > Nope, your suggest is a good one.
> > 
> > Shall I resent or are you ok for me to do this change as I commit?
> 
> Please go ahead, but can you please first double check that it still
> does actually still edit the config file as desired and cause the test
> failure on your machine ?  It would be annoying if that line ceased to
> take effect and the job spuriously passed.

I checked both the pvh and non-pvh job and they did/didn't contain a
pvh=1 as expected.

> That said,
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks. As discussed on IRC I've added it to my to-push queue which is
pending the current pretest stuff propagating. I'll flush that once I
see a pass of osstest's own gate.

The queue contains:
$ git log --oneline origin/pretest..pretest 
082e565 Add basic PVH flights.
1f110e8 Osstest/Debian: support adding a rootdelay property to bootargs
f254b4d Osstest/Debian: Add support for "ExtraInitramfsModules" host property
7d8be54 Osstest/Debian: Refactor code to set bootargs in u-boot script
1b01799 ts-debian-install: rename cfg_xend to cfg
1f48acb gitignore: ignore images directory
1b95fe3 README: list chiark-utils-bin as requirement
abc19f4 TestSupport: allow overriding of on_* in prepareguest_part_xencfg

It's also in the pretest branch of my osstest tree on xenbits.

(Wei, just FYI since some patches of yours are in there)

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel