Re: [Xen-devel] [PATCH] domctl: fix IRQ permission granting/revocation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.12.14 at 11:19, <julien.grall@xxxxxxxxxx> wrote:
> Hi Jan,
> 
> On 10/12/2014 08:07, Jan Beulich wrote:
>> Commit 545607eb3c ("x86: fix various issues with handling guest IRQs")
>> wasn't really consistent in one respect: The granting of access to an
>> IRQ shouldn't assume the pIRQ->IRQ translation to be the same in both
>> domains. In fact it is wrong to assume that a translation is already/
>> still in place at the time access is being granted/revoked.
> 
> With the change to the interface, some part of libxl may misuse 
> xc_domain_irq_permission. For instance in tools/libxl/libxl_create.c:
> 
> 1178         ret = irq >= 0 ? xc_physdev_map_pirq(CTX->xch, domid, irq, 
> &irq)
> 
> We get the PIRQ of domain domid in irq.
> 
> 1179                        : -EOVERFLOW;
> 1180         if (!ret)
> 1181             ret = xc_domain_irq_permission(CTX->xch, domid, irq,
> 1)
> 
> Here, the PIRQ of the current domain should be passed. Fortunately, for 
> this specific case, the PIRQs are the same. But this is confusing.

Agreed, but I'd leave it to the tools maintainers to clean this up.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel