Re: [Xen-devel] [PATCH v2 14/19] hvmloader: construct SLIT

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.12.14 at 16:33, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/tools/firmware/hvmloader/acpi/build.c
> +++ b/tools/firmware/hvmloader/acpi/build.c
> @@ -263,6 +263,38 @@ static struct acpi_20_srat *construct_srat(void)
>      return srat;
>  }
>  
> +static struct acpi_20_slit *construct_slit(void)
> +{
> +    struct acpi_20_slit *slit;
> +    unsigned int num, size;
> +    int i;

unsigned int please. Plus similar coding style issues further down as in
the previous patch.

> @@ -415,6 +448,11 @@ static int construct_secondary_tables(unsigned long 
> *table_ptrs,
>              table_ptrs[nr_tables++] = (unsigned long)srat;
>          else
>              printf("Failed to build SRAT, skipping...\n");
> +        slit = construct_slit();
> +        if (srat)

DYM slit?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel