[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-xen-4.5 1/3] tools/hotplug: distclean target should remove files generated by configure



On Tue, 2014-12-02 at 16:16 +0100, Daniel Kiper wrote:

> +distclean:
> +     rm -f Linux/init.d/sysconfig.xencommons Linux/init.d/xencommons 
> NetBSD/rc.d/xencommons

Configure generates a boatload more things than this, see e.g. 

$ grep hotplug/ tools/configure.ac 

Perhaps the answer would be to recurse into tools/hotplug/* and refactor
the existing XEN_SCRIPTS to have the generated stuff in XEN_SCRIPTS_GEN
instead and XEN_SCRIPTS += $(XEN_SCRIPTS). The on distclean remove the
XEN_SCRIPTS_GEN ones.

It's not ideal, but at least it puts the distclean logic in the same
place as the logic to install the files, if not their generation, which
at least increases the chance of someone adding it to the right place.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.