Re: [Xen-devel] [PATCH v2 02/19] xen: make two memory hypercalls vNUMA-aware

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.12.14 at 16:33, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/xen/common/kernel.c
> +++ b/xen/common/kernel.c
> @@ -302,6 +302,7 @@ DO(xen_version)(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>          {
>          case 0:
>              fi.submap = 0;
> +            fi.submap |= (1U << XENFEAT_memory_op_vnode_supported);

Why don't you just replace the assignment above?

> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -692,6 +692,49 @@ out:
>      return rc;
>  }
>  
> +static int translate_vnode_to_pnode(struct domain *d,
> +                                    struct xen_memory_reservation *r,
> +                                    struct memop_args *a)
> +{
> +    int rc = 0;
> +    unsigned int vnode, pnode;
> +
> +    /* Note: we don't strictly require non-supported bits set to zero,

Coding style.

With these fixed,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel