Re: [Xen-devel] [PATCH] tools/xenstore: fix link error with libsystemd

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, Dec 05, 2014 at 10:53:03AM +0000, Ian Campbell wrote:
> On Fri, 2014-12-05 at 11:49 +0100, Olaf Hering wrote:
> > Linking fails with undefined reference to the used systemd functions.
> > Move LDFLAGS after the object files to fix the failure.
> > 
> > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> This should go into 4.5.

Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> FWIW my suspicion is that this relates to toolstacks using --as-needed
> by default.
> 
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  tools/xenstore/Makefile | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
> > index bff9b25..11b6a06 100644
> > --- a/tools/xenstore/Makefile
> > +++ b/tools/xenstore/Makefile
> > @@ -74,10 +74,10 @@ endif
> >  init-xenstore-domain.o: CFLAGS += $(CFLAGS_libxenguest)
> >  
> >  init-xenstore-domain: init-xenstore-domain.o $(LIBXENSTORE)
> > -   $(CC) $(LDFLAGS) $^ $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) 
> > $(LDLIBS_libxenstore) -o $@ $(APPEND_LDFLAGS)
> > +   $(CC) $^ $(LDFLAGS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) 
> > $(LDLIBS_libxenstore) -o $@ $(APPEND_LDFLAGS)
> >  
> >  xenstored: $(XENSTORED_OBJS)
> > -   $(CC) $(LDFLAGS) $^ $(LDLIBS_libxenctrl) $(SOCKET_LIBS) -o $@ 
> > $(APPEND_LDFLAGS)
> > +   $(CC) $^ $(LDFLAGS) $(LDLIBS_libxenctrl) $(SOCKET_LIBS) -o $@ 
> > $(APPEND_LDFLAGS)
> >  
> >  xenstored.a: $(XENSTORED_OBJS)
> >     $(AR) cr $@ $^
> > @@ -86,13 +86,13 @@ $(CLIENTS): xenstore
> >     ln -f xenstore $@
> >  
> >  xenstore: xenstore_client.o $(LIBXENSTORE)
> > -   $(CC) $(LDFLAGS) $< $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ 
> > $(APPEND_LDFLAGS)
> > +   $(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ 
> > $(APPEND_LDFLAGS)
> >  
> >  xenstore-control: xenstore_control.o $(LIBXENSTORE)
> > -   $(CC) $(LDFLAGS) $< $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ 
> > $(APPEND_LDFLAGS)
> > +   $(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ 
> > $(APPEND_LDFLAGS)
> >  
> >  xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
> > -   $(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS)
> > +   $(CC) $^ $(LDFLAGS) -o $@ $(APPEND_LDFLAGS)
> >  
> >  libxenstore.so: libxenstore.so.$(MAJOR)
> >     ln -sf $< $@
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel