Re: [Xen-devel] [PATCH v2] console: increase initial conring size

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, Dec 05, 2014 at 04:21:35PM +0000, Jan Beulich wrote:
> >>> On 05.12.14 at 16:50, <daniel.kiper@xxxxxxxxxx> wrote:
> > This bug (or lack of feature if you prefer) should be fixed, as it
> > was pointed out by Jan Beulich and Olaf Hering, by allocating conring
> > earlier. I though about that before posting this patch (I did not
> > know beforehand about Olaf's work made in 2011). However, I stated
> > that it is too late to make so intrusive changes.
> 
> I continue to disagree. If anything, I'd rather see us hide (e.g. behind
> opt_cpu_info) some of the worst offenders causing the log to become
> that large. Even if yielding a bigger patch, that would have less impact

Nowadays the worst offender is the EFI memmap which can be quite
big. We could hide it behind 'opt_efi_info' and only print out some
rather odd entries. But that would be 4.6 material, while this
patch nicely fixes it for 4.5.

> functionality wise and likely benefit more people. Nor do I see the
> change to move the allocation earlier all that intrusive.
> 
> But then again, considering that all you enlarge is an __initdata item,
> perhaps this is acceptable.

This has the other side-benefit that it will help us troubleshoot in
the field without having the customer try extra parameters to extend
the log data.

I am all up for less round-trip to troubleshoot issues and I can't
see this causing any regressions (unless we have some hard-coded EFL
section data).


> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel